From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933477AbbBBUYK (ORCPT ); Mon, 2 Feb 2015 15:24:10 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46634 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932927AbbBBUYI (ORCPT ); Mon, 2 Feb 2015 15:24:08 -0500 Date: Mon, 2 Feb 2015 20:23:56 +0000 From: Mark Brown To: Dan Carpenter Cc: Bhuvanchandra DV , stefan@agner.ch, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150202202356.GF21293@sirena.org.uk> References: <1422722005-1616-1-git-send-email-bhuvanchandra.dv@toradex.com> <20150131164648.GR6507@mwanda> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lVtahNjrsivmdWUV" Content-Disposition: inline In-Reply-To: <20150131164648.GR6507@mwanda> X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip' X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lVtahNjrsivmdWUV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 31, 2015 at 07:46:48PM +0300, Dan Carpenter wrote: > On Sat, Jan 31, 2015 at 10:03:25PM +0530, Bhuvanchandra DV wrote: > > Move the check for spi->bits_per_word > > before allocation, to avoid memory leak. > > Signed-off-by: Dan Carpenter > Normally, you would give me a Reported-by: tag. Not a big deal either > way. It is a big deal - the Signed-off-by involves all the stuff in SubmittingPatches which means that you really shouldn't add a signoff for anyone who didn't supply one. I've changed to a Reported-by and applied, please be more careful with this in future Bhuvanchandra. --lVtahNjrsivmdWUV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJUz9zbAAoJECTWi3JdVIfQkJoIAIAoEwhc812HI/ImeWiYekh3 y4HtTvDApd4VOBicEMxEYBkAeC+F90IxdhEp8TPZcNqXJ30T23C1ezR7mLpxwCmD /Ba5YrrNRrsvfCqV260JF76NNmQpiRkZE+dQVNMK1XhG/LUPcKvH4SBACBSBdXyv Ss/v+Jebe37SGjDfiDOAEJkFeZ6q09TcrGgaQkzrZFnS6+7+Tc0tgWtb5KB/MX7e a+NSyca6FdhGReqCPWwcWDHjP5w7gC4A+qkk6KYuqhqIj1VtQ2m4IDI1oMZZxZ5m AIwAMlOB14v2E78E3sETV5lvMDYrnZKHjhzs+9jcGTGbOpEApaqime0ROqDUmmo= =q3U/ -----END PGP SIGNATURE----- --lVtahNjrsivmdWUV--