From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755510AbbBBXQD (ORCPT ); Mon, 2 Feb 2015 18:16:03 -0500 Received: from spo001.leaseweb.nl ([83.149.101.17]:57845 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751854AbbBBXQA (ORCPT ); Mon, 2 Feb 2015 18:16:00 -0500 Date: Tue, 3 Feb 2015 00:15:51 +0100 From: Wim Van Sebroeck To: Masanari Iida Cc: thomas.mingarelli@hp.com, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c Message-ID: <20150202231551.GA16749@spo001.leaseweb.nl> References: <1413977075-8938-1-git-send-email-standby24x7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413977075-8938-1-git-send-email-standby24x7@gmail.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masanari, > allow_kdump was enabled as default since following commit. > > commit a089361cf5f1d6a5295aa5385238bd044998e1e9, > watchdog: hpwdt: Unregister NMI events on exit. > > But the initialization message was not modified. > So it still shows > > HP Watchdog Timer Driver: NMI decoding initialized, > allow kernel dump: ON (default = 0/OFF) <= > > This "default = 0/OFF" message may confuse users. > Fix it as "default = 1/ON". > > Signed-off-by: Masanari Iida Patch has been added to linux-watchdog-next. Kind regards, Wim.