Re: [PATCH] Add ARCH_MIGHT_HAVE_VGA_CONSOLE

[Stephen Rothwell <sfr@canb.auug.org.au>]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

Hi Arnd,

On Mon, 02 Feb 2015 21:11:50 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tuesday 03 February 2015 00:48:20 Yoshinori Sato wrote:
> 
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -76,6 +76,7 @@ config ARM
> >        select PERF_USE_VMALLOC
> >        select RTC_LIB
> >        select SYS_SUPPORTS_APM_EMULATION
> >+       select ARCH_MIGHT_HAVE_VGA_CONSOLE if ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER
> >        # Above selects are sorted alphabetically; please add new ones
> >        # according to that.  Thanks.
> >        help
> 
> You did not read the comment in the patch context: This list of selects is
> sorted alphabetically in order to avoid merge conflicts. Please keep it this
> way.

Why would you not just put the "select ARCH_MIGHT_HAVE_VGA_CONSOLE"
under each of those other config symbols and further restrict the
possibility of conflicts?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]