From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966049AbbBCQJo (ORCPT ); Tue, 3 Feb 2015 11:09:44 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49276 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965920AbbBCQJl (ORCPT ); Tue, 3 Feb 2015 11:09:41 -0500 Date: Tue, 3 Feb 2015 16:09:28 +0000 From: Mark Brown To: Guenter Roeck Cc: Lars-Peter Clausen , Robert Rosengren , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jean Delvare Message-ID: <20150203160928.GN21293@sirena.org.uk> References: <1422834481-6936-1-git-send-email-linux@roeck-us.net> <54CF50CF.7040601@metafoo.de> <20150202115638.GK21293@sirena.org.uk> <54CF89EA.9040206@roeck-us.net> <20150203114210.GG21293@sirena.org.uk> <54D0D979.30307@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q4oqQF3OceNVEoAM" Content-Disposition: inline In-Reply-To: <54D0D979.30307@roeck-us.net> X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: Fix i2c word access when using SMBus access functions X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Q4oqQF3OceNVEoAM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 03, 2015 at 06:21:45AM -0800, Guenter Roeck wrote: > On 02/03/2015 03:42 AM, Mark Brown wrote: > >Perhaps it just needs to be more explicit about how it's handling native > >endian? I didn't spot it. > Thinking about it, we should actually reject requests for _NATIVE. SMBus > 16 bit accesses are either little endian or big endian. Yes, that makes sense. It's also hard to see a use case for _NATIVE and smbus. > >>I thought about that, but since the smbus functions perform endianness > >>conversion it would mean that I would have to undo that conversion just > >>to have it done again. > >No, the whole point is that by doing this you avoid any endianness > >conversions or formatting in the framework at all so you can just use > >the smbus functions to handle the formatting. > Ah, guess I got confused. The SMBus accesses are already using reg_read > and reg_write. It's also possible that you've spotted some bug, wouldn't be the first time. Was this spotted by code inspection or by running into a problem? --Q4oqQF3OceNVEoAM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU0PK3AAoJECTWi3JdVIfQT6cH/1/YtHl2TpdDIKjO9ZXJCa3m 3Du/IwIbHw5PRvuT7PjmlF0VEm//cOWI12hNIRKnDHcMuOkk8rBxtlnah7ylPV/e PapjZWb96y+A71HyptQgN4Nqq54rFv+qYmy6XFhb6En37+GustwnLZIm1r9AikkH M6hcVncOGN/wDbZg+P22xe9m+DombbqXyZD1RwuEB0q6CkSvIkzltqCpJ5g35g8l ncoIXs548t8Wq+GDtEofi5qU8oAl7wmCeyMMwf8jfoAx5t0Eqhw6Q8saZxgmKsnr VlzHnDl5GnBRW+ymqdBCMpo4frKZwwjOOZ+eFdtKu3ivRr/ge3B5QNQp9nI8U9w= =y5AP -----END PGP SIGNATURE----- --Q4oqQF3OceNVEoAM--