From: Mark Brown <broonie@kernel.org>
To: Jaewon Kim <jaewon02.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
SangBae Lee <sangbae90.lee@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Sebastian Reichel <sre@kernel.org>,
Beomho Seo <beomho.seo@samsung.com>
Subject: Re: [PATCH v2 5/6] regulator: max77843: Add max77843 regulator driver
Date: Tue, 3 Feb 2015 16:25:37 +0000 [thread overview]
Message-ID: <20150203162536.GQ21293@sirena.org.uk> (raw)
In-Reply-To: <1422939846-29955-6-git-send-email-jaewon02.kim@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Tue, Feb 03, 2015 at 02:04:05PM +0900, Jaewon Kim wrote:
> This patch adds new regulator driver to support max77843
> MFD(Multi Function Device) chip`s regulators.
> The Max77843 has two voltage regulators for USB safeout.
This looks mostly good, a couple of very small things:
> +static const struct regulator_desc max77843_supported_regulators[] = {
> + [MAX77843_SAFEOUT1] = {
> + .name = "SAFEOUT1",
> + .id = MAX77843_SAFEOUT1,
> + .ops = &max77843_regulator_ops,
> + .of_match = of_match_ptr("SAFEOUT1"),
> + .regulators_node = of_match_ptr("regulators"),
> + .type = REGULATOR_VOLTAGE,
> + .owner = THIS_MODULE,
> + .n_voltages = MAX77843_SUPPORTED_VOLTAGE_NUM,
> + .volt_table = max77843_regulator_table,
It's better to make n_voltages be ARRAY_SIZE() for the table, that way
there's no need to keep the define and array lined up if someone extends
the driver. A name like _safeout_voltage_table might be clearer too.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-02-03 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 5:04 [PATCH v2 0/6] Add new MFD driver for MAX77843 Jaewon Kim
2015-02-03 5:04 ` [PATCH v2 1/6] mfd: max77843: Add max77843 MFD driver core driver Jaewon Kim
2015-02-03 23:57 ` Chanwoo Choi
2015-02-04 2:06 ` Jaewon Kim
2015-02-03 5:04 ` [PATCH v2 2/6] extcon: max77843: Add max77843 MUIC driver Jaewon Kim
2015-02-03 23:41 ` Chanwoo Choi
2015-02-03 5:04 ` [PATCH v2 3/6] power: max77843_charger: Add Max77843 charger device driver Jaewon Kim
2015-02-03 5:04 ` [PATCH v2 4/6] power: max77843_battery: Add Max77843 fuel gauge " Jaewon Kim
2015-02-03 5:04 ` [PATCH v2 5/6] regulator: max77843: Add max77843 regulator driver Jaewon Kim
2015-02-03 16:25 ` Mark Brown [this message]
2015-02-04 1:37 ` Jaewon Kim
2015-02-03 5:04 ` [PATCH v2 6/6] Documentation: Add device tree bindings document for max77843 Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203162536.GQ21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=beomho.seo@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sangbae90.lee@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®