From: Jonathan Corbet <corbet@lwn.net>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: mchehab@osg.samsung.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media:ic:Remove calls to msleep from the functions,ov7670_s_vflip and ov7670_s_hflip
Date: Tue, 3 Feb 2015 17:56:55 -0500 [thread overview]
Message-ID: <20150203175655.668b51ab@lwn.net> (raw)
In-Reply-To: <1422938417-21874-1-git-send-email-xerofoify@gmail.com>
On Mon, 2 Feb 2015 23:40:17 -0500
Nicholas Krause <xerofoify@gmail.com> wrote:
> Removes the no longer required calls to msleep for the duration of 10 miliseconds
> in the functions,ov7670_s_vflip and ov7670_s_hflip respectfully due to no need
> for a delayed sleep of this duration in either function.
So I'm assuming you have the hardware and have verified that it still
works in the absence of these delays?
No, of course you haven't. You don't understand why the delays are
there, or why they might have a FIXME comment on them.
Nick, surely you've understood by now that this is not the right place to
be putting your energy? A FIXME comment almost never indicates an issue
that can be trivially resolved; it indicates something that the developer
who wrote the code didn't see a solution to at the time. Why do you
think you can resolve those issues without understanding them, without
understanding the hardware, and without testing your work?
But then, others have tried to convey this point to you in the past; no
reason to believe I'll be any more successful.
Please do not send this patch again.
jon
parent reply other threads:[~2015-02-03 22:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1422938417-21874-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203175655.668b51ab@lwn.net \
--to=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®