From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934145AbbBDBRh (ORCPT ); Tue, 3 Feb 2015 20:17:37 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:52175 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbbBDBRc (ORCPT ); Tue, 3 Feb 2015 20:17:32 -0500 Date: Tue, 3 Feb 2015 18:17:21 -0700 From: Gilad Avidov To: Stanimir Varbanov Cc: sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, iivanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org Subject: Re: [PATCH V2 1/2] spmi: remove wakeup command before slave probe Message-ID: <20150203181721.6bf24e59@gavidov-lnx.qualcomm.com> In-Reply-To: <54D096B8.4060408@mm-sol.com> References: <1422665201-25569-1-git-send-email-gavidov@codeaurora.org> <1422665201-25569-2-git-send-email-gavidov@codeaurora.org> <54D096B8.4060408@mm-sol.com> Organization: Qualcomm Innovation Center, Inc. X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stan, On Tue, 03 Feb 2015 11:36:56 +0200 Stanimir Varbanov wrote: > On 01/31/2015 02:46 AM, Gilad Avidov wrote: > > According to spmi spec a slave powers up into startup state and then > > transitions into active state. Thus, the wakeup command is not > > required before calling the slave's probe. The wakeup command is > > only needed for slaves that are in sleep state after receiving the > > sleep command. > > > > This is a bug since spmi master controllers, such as spmi-pmic-arb, > > which have no support for wakeup command return an error on that > > command and thus fail before reaching a slave driver probe. > > > > Cc: galak@codeaurora.org > > Acked-by: Sagar Dharia > > Signed-off-by: Gilad Avidov > > --- > > drivers/spmi/spmi.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c > > index 1d92f51..9ff7454 100644 > > --- a/drivers/spmi/spmi.c > > +++ b/drivers/spmi/spmi.c > > @@ -1,4 +1,4 @@ > > -/* Copyright (c) 2012-2013, The Linux Foundation. All rights > > reserved. +/* Copyright (c) 2012-2015, The Linux Foundation. All > > rights reserved. > > run chackpatch please. I have run checkpatch again on both my patch and the email sent by me and both pass on my machine: ~/upstream/linux$ scripts/checkpatch.pl "[PATCH V2 1_2] spmi: remove wakeup command before slave probe" total: 0 errors, 0 warnings, 23 lines checked [PATCH V2 1_2] spmi: remove wakeup command before slave probe has no obvious style problems and is ready for submission. I have also updated the source tree today, so it checkpatch's latest version. Additionally my colleague have tested on her machine and it passes for here too. Thanks, Gilad > > >