From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161263AbbBEAIV (ORCPT ); Wed, 4 Feb 2015 19:08:21 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39730 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755371AbbBEAIU (ORCPT ); Wed, 4 Feb 2015 19:08:20 -0500 Date: Wed, 04 Feb 2015 16:08:17 -0800 (PST) Message-Id: <20150204.160817.1551916015584303515.davem@davemloft.net> To: sasha.levin@oracle.com Cc: linux-kernel@vger.kernel.org, chien.yen@oracle.com, rds-devel@oss.oracle.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: rds: use correct size for max unacked packets and bytes From: David Miller In-Reply-To: <1422971760-8217-1-git-send-email-sasha.levin@oracle.com> References: <1422971760-8217-1-git-send-email-sasha.levin@oracle.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Feb 2015 16:08:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sasha Levin Date: Tue, 3 Feb 2015 08:55:58 -0500 > Max unacked packets/bytes is an int while sizeof(long) was used in the > sysctl table. > > This means that when they were getting read we'd also leak kernel memory > to userspace along with the timeout values. > > Signed-off-by: Sasha Levin Applied, thanks.