From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964965AbbBDL0Y (ORCPT ); Wed, 4 Feb 2015 06:26:24 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50299 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbbBDL0W (ORCPT ); Wed, 4 Feb 2015 06:26:22 -0500 Date: Wed, 4 Feb 2015 11:26:12 +0000 From: Mark Brown To: Nicholas Mc Guire Cc: Nicolas Ferre , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150204112612.GX21293@sirena.org.uk> References: <1422891811-28541-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9Jsz9XfKtAbN70/g" Content-Disposition: inline In-Reply-To: <1422891811-28541-1-git-send-email-hofrat@osadl.org> X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] spi: atmel: cleanup wait_for_completion return handling X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9Jsz9XfKtAbN70/g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 02, 2015 at 10:43:31AM -0500, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int, this > patch adds an appropriate variable and fixes up the assignment. It remove= s=20 > the else branch as the only thing it was doing is assigning ret =3D 0; - = but=20 > ret is never used thereafter so that is not needed. As the string in=20 > dev_err already states "timeout" there is little point in printing the 0.= =20 > A typo in "trasfer" -> transfer is also fixed. Applied, thanks. --9Jsz9XfKtAbN70/g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU0gHTAAoJECTWi3JdVIfQA0IH/3qLR4UR4mW73VR2k4Z8+EoN KoUzzhGdlaKRr/UnTDt8paGgFac1vFpdg8BgbPJTbsUtsf5tYHmldxMJg8oLoJKJ 1xx9Tj0CKGT15QL9uY4esaKVLHCqPFeePDik+UpBH0MM3QSaFm+y/t6xHj56pCwA EmbtKWsdabszDBnPqd1s99h4XwIU2ObL6sqFiqU2WWtSp650DZeDFv+YaxTot8rI mpe/sl/GWNIfqugzfQPGh9TVhxSWRVAf0S4nS2lfqDD56Pr8dyLEU2hX67CV7BHo QHuHxlLBqqGoDrfm9/ez0ktdpPotDSmpCUyhhBwykEJm9bKw9hwq5K4AMGqlq6o= =Ns8l -----END PGP SIGNATURE----- --9Jsz9XfKtAbN70/g--