From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753005AbbBEWjJ (ORCPT ); Thu, 5 Feb 2015 17:39:09 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48425 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbbBEWjH convert rfc822-to-8bit (ORCPT ); Thu, 5 Feb 2015 17:39:07 -0500 Date: Thu, 05 Feb 2015 14:39:06 -0800 (PST) Message-Id: <20150205.143906.2233107149659287418.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: mu@miroslavurbanek.com, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, tc@excello.cz, jh@excello.cz, fan.du@windriver.com Subject: Re: [PATCH] flowcache: Fix kernel panic in flow_cache_flush_task From: David Miller In-Reply-To: <1423154648.31870.81.camel@edumazet-glaptop2.roam.corp.google.com> References: <20150205153649.GA3278@miroslavurbanek.com> <1423154648.31870.81.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-15 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Feb 2015 14:39:07 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Thu, 05 Feb 2015 08:44:08 -0800 > On Thu, 2015-02-05 at 16:36 +0100, Miroslav Urbanek wrote: >> flow_cache_flush_task references a structure member flow_cache_gc_work >> where it should reference flow_cache_flush_task instead. >> >> Kernel panic occurs on kernels using IPsec during XFRM garbage >> collection. The garbage collection interval can be shortened using the >> following sysctl settings: >> >> net.ipv4.xfrm4_gc_thresh=4 >> net.ipv6.xfrm6_gc_thresh=4 >> >> With the default settings, our productions servers crash approximately >> once a week. With the settings above, they crash immediately. >> >> Fixes: ca925cf1534e ("flowcache: Make flow cache name space aware") >> Reported-by: TomᨠCharvát >> Tested-by: Jan Hejl >> Signed-off-by: Miroslav Urbanek >> --- > > Nice catch ! > > Ok, but you do not need to cc so many people/lists > > netdev is fine, and we usually CC patch author, just in case. > > Acked-by: Eric Dumazet Applied, thanks.