From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbbBEWt4 (ORCPT ); Thu, 5 Feb 2015 17:49:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37382 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbbBEWtz (ORCPT ); Thu, 5 Feb 2015 17:49:55 -0500 Date: Thu, 5 Feb 2015 14:49:54 -0800 From: Andrew Morton To: Masami Hiramatsu Cc: Ingo Molnar , tixy@linaro.org, Wang Nan , linux@arm.linux.org.uk, Linux Kernel Mailing List , lizefan@huawei.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -tip/urgent 1/2] [BUGFIX]kprobes: set kprobes_all_disarmed earlier to enable re-optimization. Message-Id: <20150205144954.d93eda6ba8be265e23037799@linux-foundation.org> In-Reply-To: <20150123064224.30731.30127.stgit@localhost.localdomain> References: <20150123064217.30731.49156.stgit@localhost.localdomain> <20150123064224.30731.30127.stgit@localhost.localdomain> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Jan 2015 15:42:24 +0900 Masami Hiramatsu wrote: > From: Wang Nan > > In original code, the probed instruction doesn't get optimized after > > echo 0 > /sys/kernel/debug/kprobes/enabled > echo 1 > /sys/kernel/debug/kprobes/enabled > > This is because original code checks kprobes_all_disarmed in > optimize_kprobe(), but this flag is turned off after calling that > function. Therefore, optimize_kprobe() will see > kprobes_all_disarmed == true and doesn't do the optimization. > > This patch simply turns off kprobes_all_disarmed earlier to enable > optimization. > > Signed-off-by: Wang Nan > Acked-by: Masami Hiramatsu You sent the patches, so this should have been "Signed-off-by:". Documentation/SubmittingPatches section 12 has the details. I have made that change to my copy of these two patches.