From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753862AbbBEVb6 (ORCPT ); Thu, 5 Feb 2015 16:31:58 -0500 Received: from smtprelay0066.hostedemail.com ([216.40.44.66]:54184 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751447AbbBEVb5 (ORCPT ); Thu, 5 Feb 2015 16:31:57 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3872:3874:5007:6261:7875:10004:10400:10471:10848:10967:11026:11232:11473:11658:11914:12114:12296:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: fowl13_853be389ff127 X-Filterd-Recvd-Size: 1534 Date: Thu, 5 Feb 2015 16:31:54 -0500 From: Steven Rostedt To: Al Viro Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 6/7] trace: constify filter_parse_regex(), match_records(), ftrace_match() and ftrace_match_record() Message-ID: <20150205163154.5bfdc29c@gandalf.local.home> In-Reply-To: <1423166200-1800-6-git-send-email-viro@ZenIV.linux.org.uk> References: <20150205194914.GR29656@ZenIV.linux.org.uk> <1423166200-1800-6-git-send-email-viro@ZenIV.linux.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Feb 2015 19:56:39 +0000 Al Viro wrote: > @@ -345,12 +346,11 @@ enum regex_type filter_parse_regex(char *buff, int *len, char **search, int *not > type = MATCH_MIDDLE_ONLY; > else > type = MATCH_FRONT_ONLY; > - buff[i] = 0; > break; > } > } > } > - *len = strlen(*search); > + *len = buff + i - *search; Heh, I guess I didn't need to mention this optimization. I would recommend that this change goes into patch 5/7. No need to place it here. It fits better with the previous patch. -- Steve > > return type; > }