From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbbBEWHs (ORCPT ); Thu, 5 Feb 2015 17:07:48 -0500 Received: from smtprelay0095.hostedemail.com ([216.40.44.95]:56523 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752149AbbBEWHq (ORCPT ); Thu, 5 Feb 2015 17:07:46 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2692:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4362:5007:6119:6261:7875:7903:8660:10004:10400:10471:10848:10967:11026:11232:11658:11914:12114:12517:12519:12740:13069:13148:13149:13230:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: sign02_95c56ad8763e X-Filterd-Recvd-Size: 2397 Date: Thu, 5 Feb 2015 17:07:43 -0500 From: Steven Rostedt To: Al Viro Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 5/7] trace: make filter_parse_regex() provide the length of substring to compare with Message-ID: <20150205170743.3c34178f@gandalf.local.home> In-Reply-To: <20150205214424.GS29656@ZenIV.linux.org.uk> References: <20150205194914.GR29656@ZenIV.linux.org.uk> <1423166200-1800-5-git-send-email-viro@ZenIV.linux.org.uk> <20150205162933.4fad48f6@gandalf.local.home> <20150205214424.GS29656@ZenIV.linux.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Feb 2015 21:44:24 +0000 Al Viro wrote: > The point is that by now this strlen() is the only thing for which we > NUL-termination of the substring; moving it inside the filter_parse_regex() > is an obviously equivalent transformation and it leaves that one strlen() call > inside filter_parse_regex() the only place where we still care about NUL. > > The next commit kills it off completely, at which point we are done with > modifying the string at all. Thanks for the explanation, Can you add that to the change log. I like to think patches can stand on their own, and if they are added to help another patch, it should be stated in the change log so someone doing a git blame followed by a git show, knows what is going on. Changes done for a patch series may be fine when that series is being reviewed, but a change log is the only thing we have in the future to understand why something was done. And a change done to help out another change is lost when going back and looking at the history. I've been burnt by my own code by looking back at why I did something and not having a change log on a change describing things to why they were done (because at the time it seemed obvious). But then I wasted a lot of time digging through archives to figure out the history of some change. I rather avoid doing that again. Thanks, -- Steve