From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752205AbbBEWws (ORCPT ); Thu, 5 Feb 2015 17:52:48 -0500 Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:59064 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751219AbbBEWwq (ORCPT ); Thu, 5 Feb 2015 17:52:46 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3871:3872:3873:3874:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12114:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: shoes19_6f5bc3d7c0231 X-Filterd-Recvd-Size: 1510 Date: Thu, 5 Feb 2015 17:52:44 -0500 From: Steven Rostedt To: Al Viro Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 1/7] trace: fix the glob match in __unregister_ftrace_function_probe() Message-ID: <20150205175244.465c629e@gandalf.local.home> In-Reply-To: <20150205223038.GV29656@ZenIV.linux.org.uk> References: <20150205194914.GR29656@ZenIV.linux.org.uk> <1423166200-1800-1-git-send-email-viro@ZenIV.linux.org.uk> <20150205154336.0be014e9@gandalf.local.home> <20150205223038.GV29656@ZenIV.linux.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Feb 2015 22:30:39 +0000 Al Viro wrote: > On Thu, Feb 05, 2015 at 03:43:36PM -0500, Steven Rostedt wrote: > > Can you make search = NULL instead of glob at the start of the > > function. That is: > > > > if (!glob || strcmp(glob, "*") == 0 || !strlen(glob)) > > search = NULL; > > Umm... If we do it that way, I'd rather initialized search with NULL > and inverted the test: > if (glob && *glob && strcmp(glob, "*") != 0) { > parse it and set search > } Fine with me. -- Steve