From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754131AbbBFK5e (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Feb 2015 05:57:34 -0500
Received: from smtp.citrix.com ([66.165.176.89]:44695 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753925AbbBFK5c (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Feb 2015 05:57:32 -0500
X-IronPort-AV: E=Sophos;i="5.09,529,1418083200"; 
   d="scan'208";a="223642289"
Date: Fri, 6 Feb 2015 10:57:30 +0000
From: Wei Liu <wei.liu2@citrix.com>
To: Bob Liu <bob.liu@oracle.com>
CC: <xen-devel@lists.xen.org>, <david.vrabel@citrix.com>,
        <linux-kernel@vger.kernel.org>, <roger.pau@citrix.com>,
        <konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>,
        <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/2] xenbus_client: extend interface to suppurt
 multi-page ring
Message-ID: <20150206105730.GB30821@zion.uk.xensource.com>
References: <1422008071-27643-1-git-send-email-bob.liu@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1422008071-27643-1-git-send-email-bob.liu@oracle.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 23, 2015 at 06:14:30PM +0800, Bob Liu wrote:
[...]
>  	rv = xenbus_alloc_evtchn(dev, &priv->evtchn);
>  	if (rv)
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 908e65e..8513764 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1955,7 +1955,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue,
>  	int err = -ENOMEM;
>  
>  	err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif),
> -				     tx_ring_ref, &addr);
> +				&tx_ring_ref, 1, &addr);
>  	if (err)
>  		goto err;
>  
> @@ -1963,7 +1963,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue,
>  	BACK_RING_INIT(&queue->tx, txs, PAGE_SIZE);
>  
>  	err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif),
> -				     rx_ring_ref, &addr);
> +				&rx_ring_ref, 1, &addr);

With my netback maintainer hat on, indentation here looks wrong. Not
sure if this is my fault when writing the original patch, but it would
be good if you fix them in next posting. :-)

Thanks
Wei.