Re: 1e918876 breaks r8169 (linux-3.18+)

[Tomas Szepe <szepe@pinerecords.com>]

> > > Since linux-3.18.0, r8169 is having problems driving one of my add-on
> > > PCIe NICs.  The interface is losing link for several seconds at a time,
> > > the frequency being about once a minute when the traffic is high.
> > > ...
> > 
> > Thanks for reporting this!  I'm no lkml subscriber and thus did not
> > see earlier report.
> 
> Np, I just like my eth interfaces being up when they're supposed to be up. :)
> 
> > I'll try to reproduce this but unfortunately I am currently travelling
> > and won't have access to my r8169 nic until Feb 10th.
> > 
> > If you're willing to experiment (not even compile tested):
> > 
> > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> > ...
> 
> I'm happy to report this patch fixes the problem (tested on vanilla
> 3.18.5), and the throughput of the link seems fine in both directions,
> too.

Unfortunately, I have to take this back.  I made the conclusion too early.
The problem appears with this patch applied, too, only perhaps later and
with a different frequency pattern.

Sorry about the confusion,
-- 
Tomas Szepe <szepe@pinerecords.com>