From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932116AbbBGI31 (ORCPT ); Sat, 7 Feb 2015 03:29:27 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54358 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756583AbbBGI3Y (ORCPT ); Sat, 7 Feb 2015 03:29:24 -0500 Date: Sat, 7 Feb 2015 06:10:58 +0800 From: Mark Brown To: Yi Zhang Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, yizhang@marvell.com, zhenzh@marvell.com, zhouqiao@marvell.com Message-ID: <20150206221058.GC31311@finisterre.sirena.org.uk> References: <7d3ec992.e522.14b5cd26cf6.Coremail.yizhanghust@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: <7d3ec992.e522.14b5cd26cf6.Coremail.yizhanghust@163.com> X-Cookie: Vitamin C deficiency is apauling. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 113.28.134.59 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [Question] should we export set_suspend_voltage()? X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 06, 2015 at 10:57:49AM +0800, Yi Zhang wrote: Please fix your mailer to word wrap within paragraphs, your mail is very difficult to read and reply to. > do you think it's good to export the set_suspend_voltage()? to make it > controllable by the regulator itself? another method in my opinion is > add a set of virtual-regulator for this usage? > could you please share your advice? There's been some discussion of this in the context of some Qualcomm systems recently, search the archives for discussions especially with Bjorn Andersson recently. The basic idea was to mirror the existing APIs but with an additional mode argument (and permisions) to allow consumers to manipulate states other than the default state. --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU1TvxAAoJECTWi3JdVIfQTfYH/1KpcWJx42msRwSnU6tsdgKS eXUpIRrx2Mlxz+PMjLFkh9JF5Oc0a5CsPAx0K/RmhC+rV4qTk8gKv1dHuvPp9z/U 2QroyRDXss+HOLRk8uWAPE5hL3krVovrGEnLUJKH4P3oFMsGgXxinWsfpRbw+RLO D/BOxDHCB13Ff/6dm07qLuFSw0Enm9s9AHrPpYJkkZ5GRg/cHi6EFUaOJ9nTtvPG nn6peJXkbPJVA469EJuIBzf+UAo2T1HDBkI+Xa7mnEYZdnVpy136VXPoCkhI2iTB Jxa6f7GBNhdH5jrIbmasSZvf95EsmYRXBiJRYbw8Zr6NUZgNN8TUEU+usrHffrw= =xXvi -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA--