mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cc: Daniel Oliveira Nascimento <don@syst.com.br>,
	Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] classmate-laptop: fix sparse warning
Date: Fri, 6 Feb 2015 20:32:35 -0200	[thread overview]
Message-ID: <20150206223234.GH2162@siri.cascardo.eti.br> (raw)
In-Reply-To: <1423148264-6877-1-git-send-email-prabhakar.csengg@gmail.com>

On Thu, Feb 05, 2015 at 02:57:44PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> this patch fixes following sparse warning:
> 
> classmate-laptop.c:523:61: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

> ---
>  Found this issue on linux-next (gcc  version 4.9.2,
>  sparse version  0.4.5-rc1) and applies on top linux-next.
> 
>  drivers/platform/x86/classmate-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 70d355a..55cf10b 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -520,7 +520,7 @@ static acpi_status cmpc_get_accel(acpi_handle handle,
>  {
>  	union acpi_object param[2];
>  	struct acpi_object_list input;
> -	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, 0 };
> +	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
>  	unsigned char *locs;
>  	acpi_status status;
>  
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-02-06 22:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 14:57 Lad Prabhakar
2015-02-06 22:32 ` Thadeu Lima de Souza Cascardo [this message]
2015-02-07 20:12 ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150206223234.GH2162@siri.cascardo.eti.br \
    --to=cascardo@holoscopio.com \
    --cc=don@syst.com.br \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®