From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758743AbbBGRLs (ORCPT ); Sat, 7 Feb 2015 12:11:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59231 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758561AbbBGRLq (ORCPT ); Sat, 7 Feb 2015 12:11:46 -0500 Date: Sat, 7 Feb 2015 17:12:07 +0800 From: Greg KH To: Frederic Jacob Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: fbtft: Fix Sparse warnings Message-ID: <20150207091207.GB907@kroah.com> References: <1422501746-9242-1-git-send-email-frederic.jacob.78@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422501746-9242-1-git-send-email-frederic.jacob.78@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 28, 2015 at 10:22:26PM -0500, Frederic Jacob wrote: > Fix Sparse warnings for undeclared symbols Huh? > > Signed-off-by: Frederic Jacob > --- > drivers/staging/fbtft/fb_hx8340bn.c | 2 +- > drivers/staging/fbtft/fbtft_device.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/fbtft/fb_hx8340bn.c b/drivers/staging/fbtft/fb_hx8340bn.c > index 3939502..26a987a 100644 > --- a/drivers/staging/fbtft/fb_hx8340bn.c > +++ b/drivers/staging/fbtft/fb_hx8340bn.c > @@ -108,7 +108,7 @@ static int init_display(struct fbtft_par *par) > return 0; > } > > -void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) > +static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) > { > fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, > "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye); > diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c > index b9f4c30..157f79c 100644 > --- a/drivers/staging/fbtft/fbtft_device.c > +++ b/drivers/staging/fbtft/fbtft_device.c > @@ -29,8 +29,8 @@ > > #define MAX_GPIOS 32 > > -struct spi_device *spi_device; > -struct platform_device *p_device; > +static struct spi_device *spi_device; > +static struct platform_device *p_device; These changes are making things static, not undeclared. Can you fix up your changelog entry to show the exact error you are fixing? thanks, greg k-h