From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759152AbbBIBPG (ORCPT ); Sun, 8 Feb 2015 20:15:06 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:34845 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759094AbbBIBPE (ORCPT ); Sun, 8 Feb 2015 20:15:04 -0500 Date: Sun, 08 Feb 2015 17:15:02 -0800 (PST) Message-Id: <20150208.171502.1797960070992248341.davem@davemloft.net> To: linux@rasmusvillemoes.dk Cc: pshelar@nicira.com, nicolas.dichtel@6wind.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vxlan: Wrong type passed to %pIS From: David Miller In-Reply-To: <1423275451-3663-1-git-send-email-linux@rasmusvillemoes.dk> References: <1423275451-3663-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sun, 08 Feb 2015 17:15:04 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Sat, 7 Feb 2015 03:17:31 +0100 > src_ip is a pointer to a union vxlan_addr, one member of which is a > struct sockaddr. Passing a pointer to src_ip is wrong; one should pass > the value of src_ip itself. Since %pIS formally expects something of > type struct sockaddr*, let's pass a pointer to the appropriate union > member, though this of course doesn't change the generated code. > > Fixes: e4c7ed415387 ("vxlan: add ipv6 support") > Signed-off-by: Rasmus Villemoes Applied, thanks.