From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbbBHG75 (ORCPT ); Sun, 8 Feb 2015 01:59:57 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:43113 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbbBHG74 (ORCPT ); Sun, 8 Feb 2015 01:59:56 -0500 Date: Sat, 7 Feb 2015 22:59:52 -0800 From: Brian Norris To: Niklas Cassel Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Ricard Wanderlof Subject: Re: [PATCH] mtd: avoid registering reboot notifier twice Message-ID: <20150208065952.GC3670@norris-Latitude-E6410> References: <1422752930-696-1-git-send-email-nks@flawful.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422752930-696-1-git-send-email-nks@flawful.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 01, 2015 at 02:08:50AM +0100, Niklas Cassel wrote: > Calling mtd_device_parse_register with the same mtd_info > (e.g. registering several partitions on a single device) > would add the same reboot notifier twice, causing an > infinte loop in notifier_chain_register during boot up. > > Signed-off-by: Niklas Cassel Begrudgingly applied to l2-mtd.git. It's better to fix this bug than for me just to complain about badly written board files and drivers... > --- > drivers/mtd/mtdcore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index de79576..98efc1e 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -556,7 +556,7 @@ int mtd_device_parse_register(struct mtd_info *mtd, const char * const *types, > err = -ENODEV; > } > Also added a FIXME comment here to note that some drivers are doing odd things to require this workaround. > - if (mtd->_reboot) { > + if (mtd->_reboot && !mtd->reboot_notifier.notifier_call) { > mtd->reboot_notifier.notifier_call = mtd_reboot_notifier; > register_reboot_notifier(&mtd->reboot_notifier); > } Brian