From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758920AbbBHUAm (ORCPT ); Sun, 8 Feb 2015 15:00:42 -0500 Received: from down.free-electrons.com ([37.187.137.238]:48800 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755039AbbBHUAl (ORCPT ); Sun, 8 Feb 2015 15:00:41 -0500 Date: Sun, 8 Feb 2015 21:00:36 +0100 From: Boris Brezillon To: Antoine Tenart Cc: sebastian.hesselbarth@gmail.com, ezequiel.garcia@free-electrons.com, dwmw2@infradead.org, computersforpeace@gmail.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/9] mtd: pxa3xx_nand: set NDCR_PG_PER_BLK if page per block is 128 Message-ID: <20150208210036.4ae2978b@bbrezillon> In-Reply-To: <1422367816-4257-4-git-send-email-antoine.tenart@free-electrons.com> References: <1422367816-4257-1-git-send-email-antoine.tenart@free-electrons.com> <1422367816-4257-4-git-send-email-antoine.tenart@free-electrons.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Antoine, On Tue, 27 Jan 2015 15:10:10 +0100 Antoine Tenart wrote: I'm not the one who should say that (I'm often sending patches without any commit message), but a short commit message explaining why you're doing that would help reviewers ;-). Best Regards, Boris > Signed-off-by: Antoine Tenart > --- > drivers/mtd/nand/pxa3xx_nand.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 2681ec4abafa..782ae24d6b7d 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -1216,7 +1216,8 @@ static int pxa3xx_nand_config_flash(struct pxa3xx_nand_info *info, > > ndcr |= (pdata->enable_arbiter) ? NDCR_ND_ARB_EN : 0; > ndcr |= (host->col_addr_cycles == 2) ? NDCR_RA_START : 0; > - ndcr |= (f->page_per_block == 64) ? NDCR_PG_PER_BLK : 0; > + ndcr |= (f->page_per_block == 64 || f->page_per_block == 128) ? > + NDCR_PG_PER_BLK : 0; > ndcr |= (f->page_size == 2048) ? NDCR_PAGE_SZ : 0; > ndcr |= (f->flash_width == 16) ? NDCR_DWIDTH_M : 0; > ndcr |= (f->dfc_width == 16) ? NDCR_DWIDTH_C : 0; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com