From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758930AbbBHUPO (ORCPT ); Sun, 8 Feb 2015 15:15:14 -0500 Received: from down.free-electrons.com ([37.187.137.238]:48831 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754334AbbBHUPN (ORCPT ); Sun, 8 Feb 2015 15:15:13 -0500 Date: Sun, 8 Feb 2015 21:15:08 +0100 From: Boris Brezillon To: Antoine Tenart Cc: sebastian.hesselbarth@gmail.com, ezequiel.garcia@free-electrons.com, dwmw2@infradead.org, computersforpeace@gmail.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/9] mtd: pxa3xx_nand: add a default chunk size Message-ID: <20150208211508.7b7d2632@bbrezillon> In-Reply-To: <1422367816-4257-5-git-send-email-antoine.tenart@free-electrons.com> References: <1422367816-4257-1-git-send-email-antoine.tenart@free-electrons.com> <1422367816-4257-5-git-send-email-antoine.tenart@free-electrons.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jan 2015 15:10:11 +0100 Antoine Tenart wrote: > Add a default chunk size of 512 in the pxa3xx nand driver. > > Signed-off-by: Antoine Tenart > --- > drivers/mtd/nand/pxa3xx_nand.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 782ae24d6b7d..b2783b1f663c 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -1430,6 +1430,9 @@ static int pxa3xx_nand_scan(struct mtd_info *mtd) > if (pdata->keep_config && !pxa3xx_nand_detect_config(info)) > goto KEEP_CONFIG; > > + /* Set a default chunk size */ Could you explain why you need to set this default chunk size ? I guess it's because your NAND is not configured by the bootloader, and thus you did not specify the keep-config attribute in the DT. And I guess you need this field to be initialized before pxa_ecc_init is called (for some NAND operations done in the meantime: READID ?). Moreover, IMHO this should be place in an 'else' statement, otherwise you'll overwrite the value set in pxa3xx_nand_detect_config. > + info->chunk_size = 512; > + > ret = pxa3xx_nand_sensing(info); > if (ret) { > dev_info(&info->pdev->dev, "There is no chip on cs %d!\n", -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com