From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbbBJUbV (ORCPT ); Tue, 10 Feb 2015 15:31:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49097 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbbBJUbT (ORCPT ); Tue, 10 Feb 2015 15:31:19 -0500 Date: Tue, 10 Feb 2015 12:31:17 -0800 From: Andrew Morton To: Chanwoo Choi Cc: a.zummo@towertech.it, kgene@kernel.org, kyungmin.park@samsung.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH] rtc: s3c: Fix the duplicate clock control Message-Id: <20150210123117.b8f3c446137f8d5fd90dda35@linux-foundation.org> In-Reply-To: <1423537650-11832-1-git-send-email-cw00.choi@samsung.com> References: <1423537650-11832-1-git-send-email-cw00.choi@samsung.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Feb 2015 12:07:30 +0900 Chanwoo Choi wrote: > This patch fixes the duplicate clock control and split out clock control > function as s3c_rtc_enable_clk()/s3c_rtc_disable_clk() to simplify code. "fixes"? This is a pretty big patch and it is poorly described. Please provide a complete description of what is wrong with the original code and how this patch alters it. Please be sure to describe the user-visible effects of the bug.