From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753367AbbBJRx2 (ORCPT ); Tue, 10 Feb 2015 12:53:28 -0500 Received: from 1wt.eu ([62.212.114.60]:26455 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbbBJRx1 (ORCPT ); Tue, 10 Feb 2015 12:53:27 -0500 Date: Tue, 10 Feb 2015 18:53:12 +0100 From: Willy Tarreau To: Sudip Mukherjee Cc: Willy Tarreau , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: panel: initialize lcd if lcd enabled Message-ID: <20150210175312.GB9067@1wt.eu> References: <1423569363-7354-1-git-send-email-sudipm.mukherjee@gmail.com> <1423569363-7354-2-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423569363-7354-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 10, 2015 at 05:26:03PM +0530, Sudip Mukherjee wrote: > initialiaze lcd parameters only if lcd is enabled. > > Signed-off-by: Sudip Mukherjee One minor comment below (cosmetic), but after this it's OK. Acked-by: Willy Tarreau > + if (lcd.enabled) { > + /* > + * Init lcd struct with load-time values to preserve exact > + * current functionality (at least for now). > + */ > + lcd.height = lcd_height; > + lcd.width = lcd_width; > + lcd.bwidth = lcd_bwidth; > + lcd.hwidth = lcd_hwidth; > + lcd.charset = lcd_charset; > + lcd.proto = lcd_proto; > + lcd.pins.e = lcd_e_pin; > + lcd.pins.rs = lcd_rs_pin; > + lcd.pins.rw = lcd_rw_pin; > + lcd.pins.cl = lcd_cl_pin; > + lcd.pins.da = lcd_da_pin; > + lcd.pins.bl = lcd_bl_pin; > + > + /* Leave it for now, just in case */ ^^^^^^^^^^^^^^^^^^^ Please fix indenting the comment here. > + lcd.esc_seq.len = -1; > + } > + Willy