From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754725AbbBKWeG (ORCPT ); Wed, 11 Feb 2015 17:34:06 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:51859 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754460AbbBKWeE (ORCPT ); Wed, 11 Feb 2015 17:34:04 -0500 Date: Wed, 11 Feb 2015 14:41:05 -0800 (PST) Message-Id: <20150211.144105.402784068369724984.davem@davemloft.net> To: geert@linux-m68k.org Cc: pshelar@nicira.com, tgraf@suug.ch, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] openvswitch: Add missing initialization in validate_and_copy_set_tun() From: David Miller In-Reply-To: <1423650218-24666-1-git-send-email-geert@linux-m68k.org> References: <1423650218-24666-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Feb 2015 14:34:03 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t1BMYApM025887 From: Geert Uytterhoeven Date: Wed, 11 Feb 2015 11:23:38 +0100 > net/openvswitch/flow_netlink.c: In function validate_and_copy_set_tun: > net/openvswitch/flow_netlink.c:1749: warning: err may be used uninitialized in this function > > If ipv4_tun_from_nlattr() returns a different positive value than > OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and > validate_and_copy_set_tun() may return an undefined value instead of a > zero success indicator. Initialize err to zero to fix this. > > Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension") > Signed-off-by: Geert Uytterhoeven Applied. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I