From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbbBKGeF (ORCPT ); Wed, 11 Feb 2015 01:34:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55594 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbbBKGeA (ORCPT ); Wed, 11 Feb 2015 01:34:00 -0500 Date: Wed, 11 Feb 2015 14:33:51 +0800 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: doubt about sm7xxfb Message-ID: <20150211063351.GB713@kroah.com> References: <20150210140747.GA15593@sudip-PC> <20150211043636.GA27598@kroah.com> <20150211062818.GA3975@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150211062818.GA3975@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 11, 2015 at 11:58:18AM +0530, Sudip Mukherjee wrote: > On Wed, Feb 11, 2015 at 12:36:36PM +0800, Greg Kroah-Hartman wrote: > > On Tue, Feb 10, 2015 at 07:37:47PM +0530, Sudip Mukherjee wrote: > > > Hi Greg, > > > we have this sm7xxfb in drivers/staging now which is supporting SM710, > > > SM712, SM721 and SM722. I am also working on another new hardware > > > SM750, which will be ready for staging in next 1 -2 weeks. > > > this SM750 is entirely different hardware and these two drivers will > > > have nothing in common. > > > > Then make a new driver! > ok, but then won't the name sm7xxfb will be misleading? Sure, but really, who cares :) > > But why would a new driver go into staging? Anything new you create > > should just go into the "correct" part of the kernel. Don't waste your > > time on staging. > > this code has been given to me by Silicon Motion, and will require a > few changes before it can be used with current kernel version. And to > merge it into video/fbdev it will require many changes and cleanups. > But to be frank this will have much less work to do compared to > sm7xxfb, but as this is not part of my dayjob i can not give my full > time to it. So I was thinking of staging. Ok, that makes sense, I was thinking this was a "new" driver, instead of a vendor driver crud. thanks, greg k-h