mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
Date: Wed, 11 Feb 2015 17:39:20 -0300	[thread overview]
Message-ID: <20150211203920.GK24251@kernel.org> (raw)
In-Reply-To: <20150211162404.GA15522@hansolo.redhat.com>

Em Wed, Feb 11, 2015 at 11:24:05AM -0500, Josh Boyer escreveu:
> The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must
> be defined before pthread.h is included in order to get the proper function
> declaration.  Define this in the Makefile.
> 
> Without this defined, the feature check fails on a Fedora system with gcc5
> and then the perf build later fails with conflicting prototypes for the
> function.
> 
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
>  tools/perf/config/feature-checks/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied

  reply	other threads:[~2015-02-11 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 16:24 Josh Boyer
2015-02-11 20:39 ` Arnaldo Carvalho de Melo [this message]
2015-02-18 18:30 ` [tip:perf/core] " tip-bot for Josh Boyer
2015-03-01 16:49 ` [tip:perf/urgent] " tip-bot for Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150211203920.GK24251@kernel.org \
    --to=acme@kernel.org \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=jolsa@kernel.org \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome