From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbbBNKa3 (ORCPT ); Sat, 14 Feb 2015 05:30:29 -0500 Received: from barbershop.grep.be ([89.106.240.122]:34614 "EHLO barbershop.grep.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753781AbbBNKa2 (ORCPT ); Sat, 14 Feb 2015 05:30:28 -0500 Date: Sat, 14 Feb 2015 11:30:24 +0100 From: Wouter Verhelst To: Markus Pargmann Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [Nbd] [PATCH 3/9] nbd: Remove kernel internal header Message-ID: <20150214103024.GF16027@grep.be> References: <1423774657-12748-1-git-send-email-mpa@pengutronix.de> <1423774657-12748-4-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423774657-12748-4-git-send-email-mpa@pengutronix.de> X-Speed: Gates' Law: Every 18 months, the speed of software halves. Organization: none User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 12, 2015 at 09:57:31PM +0100, Markus Pargmann wrote: > The header is not included anywhere. Remove it and include the private > nbd_device struct in nbd.c. It exists mostly for the benefit of userspace trying to speak the NBD protocol. I've stopped trying to depend on it (since nbd-server needs to run on !Linux, too), but there are other implementations that might want to use it. nbd.h is part of a public API. Let's not drop it. -- It is easy to love a country that is famous for chocolate and beer -- Barack Obama, speaking in Brussels, Belgium, 2014-03-26