From: Jeff Layton <jlayton@poochiereds.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <david@fromorbit.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [GIT PULL] please pull file-locking related changes for v3.20
Date: Mon, 16 Feb 2015 19:35:28 -0500 [thread overview]
Message-ID: <20150216193528.55794f47@tlielax.poochiereds.net> (raw)
In-Reply-To: <CA+55aFzOU93LvBLWw5vvLLFFsMiHJuH8Yc=Zn4N6NSDwp5acUg@mail.gmail.com>
On Mon, 16 Feb 2015 16:21:30 -0800
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, Feb 16, 2015 at 4:02 PM, Jeff Layton <jlayton@poochiereds.net> wrote:
> >
> > Now that I look, it may be best to just revert this whole set for now.
> > Linus, are you amenable to doing that?
>
> Sure. But I'd prefer seeing how hard it would be to fix things first.
> If this was at the end of the release cycle, I'd revert it
> immediately. As it is, try to see how had it is.
>
Fair enough. I just didn't want to hold up -rc1. I should be able to
fix up the bugs within the next day or so.
I've got a small stack of fixes that I'll send along soon.
> The bugs I found might be as easy as just the attached (TOTALLY
> UNTESTED) patch. The comment about a higher-priority process and
> sched_resced() is just complete and utter crap. If somebody holds a
> read lock and upgrades it to a write lock, there is absolutely *zero*
> reason to let some higher-priority process get the write-lock first -
> that's just simply semantically wrong bullshit. "Higher priority" does
> not mean "can punch through locks".
>
The patch is pretty close to one that I have, so yes I think that will fix
it. There is one bug in the first loop though -- "old_fl" should be set
to "fl" there.
I'm also happy to remove the "drop the spinlock" thing. It's bothered
me for a while...
> Removing the silly incorrect counts should be trivial too. There
> really are not very many users, and they can just walk the list
> instead.
>
Yes, that's a straightforward revert.
> Now, if you've found other more fundamental bugs that look unfixable,
> then that might mean that reverting it all is unavoidable, but..
>
> Linus
No, I don't think there's anything unfixable there. I did find another
bug, but it's simple to fix.
--
Jeff Layton <jlayton@poochiereds.net>
next prev parent reply other threads:[~2015-02-17 0:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 10:55 Jeff Layton
2015-02-16 13:32 ` Kirill A. Shutemov
2015-02-16 14:00 ` Jeff Layton
2015-02-16 18:46 ` Linus Torvalds
2015-02-16 19:24 ` Linus Torvalds
2015-02-16 19:59 ` Jeff Layton
2015-02-17 0:02 ` Jeff Layton
2015-02-17 0:21 ` Linus Torvalds
2015-02-17 0:35 ` Jeff Layton [this message]
2015-02-17 19:08 ` J. Bruce Fields
2015-02-17 19:13 ` Linus Torvalds
2015-02-17 19:27 ` Jeff Layton
2015-02-17 19:41 ` Linus Torvalds
2015-02-17 19:45 ` J. Bruce Fields
2015-02-17 20:12 ` Jeff Layton
2015-02-17 20:17 ` Linus Torvalds
2015-02-17 19:29 ` Linus Torvalds
2015-02-26 11:00 ` One Thousand Gnomes
2015-02-26 14:45 ` J. Bruce Fields
2015-02-26 15:09 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216193528.55794f47@tlielax.poochiereds.net \
--to=jlayton@poochiereds.net \
--cc=bfields@fieldses.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®