From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756308AbbBQMxr (ORCPT ); Tue, 17 Feb 2015 07:53:47 -0500 Received: from www.linutronix.de ([62.245.132.108]:43621 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756283AbbBQMxp (ORCPT ); Tue, 17 Feb 2015 07:53:45 -0500 Date: Tue, 17 Feb 2015 13:53:42 +0100 From: Sebastian Andrzej Siewior To: Mike Galbraith Cc: Steven Rostedt , LKML , linux-rt-users , Thomas Gleixner , Carsten Emde , John Kacur , Clark Williams Subject: Re: 3.14.23-rt20 - aio: fix rcu garbage collection might_sleep() splat Message-ID: <20150217125342.GJ26177@linutronix.de> References: <20141031170326.1491a63f@gandalf.local.home> <1414910967.5380.81.camel@marge.simpson.net> <1414913488.5380.115.camel@marge.simpson.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1414913488.5380.115.camel@marge.simpson.net> X-Key-Id: 97C4700B X-Key-Fingerprint: 09E2 D1F3 9A3A FF13 C3D3 961C 0688 1C1E 97C4 700B User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mike Galbraith | 2014-11-02 08:31:28 [+0100]: >(not pretty) You do the RCU thingy and replace locking. Is this required after the patch I've sent in "Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat"? From a quick browse I've seen that ffs_epfile_aio_write() invokes kiocb_set_cancel_fn(, ffs_aio_cancel) and the function does hold a sleeping lock. Sebastian