From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbBQWwt (ORCPT ); Tue, 17 Feb 2015 17:52:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37067 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752444AbbBQWws (ORCPT ); Tue, 17 Feb 2015 17:52:48 -0500 Date: Tue, 17 Feb 2015 14:52:46 -0800 From: Andrew Morton To: Joe Perches Cc: LKML Subject: Re: [PATCH] ipc: Remove uses of return value of seq_printf/seq_puts Message-Id: <20150217145246.e0821f61bcebe2e50b057ef9@linux-foundation.org> In-Reply-To: <1424202288.25416.5.camel@perches.com> References: <1424202288.25416.5.camel@perches.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Feb 2015 11:44:48 -0800 Joe Perches wrote: > These functions are soon going to return void That's news to me. > so remove the > return value uses. > > Convert the return value to test seq_has_overflowed() instead. Why not make seq_printf() return seq_has_overflowed()? I'm sure it's all very sensible, but the changelogging is poor. Perhaps doing all this in a coherent patch series would be a better way.