From: Andrew Morton <akpm@linux-foundation.org>
To: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
Cc: "'viro@zeniv.linux.org.uk'" <viro@zeniv.linux.org.uk>,
"'linux-fsdevel@vger.kernel.org'" <linux-fsdevel@vger.kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"Gao, Neil" <Neil.Gao@sonymobile.com>
Subject: Re: [RFC V3] test bit before clear files_struct bits
Date: Wed, 18 Feb 2015 13:27:15 -0800 [thread overview]
Message-ID: <20150218132715.be18865751a83820f635f04e@linux-foundation.org> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D10458D6173BCC@CNBJMBX05.corpusers.net>
On Sun, 15 Feb 2015 16:27:27 +0800 "Wang, Yalin" <Yalin.Wang@sonymobile.com> wrote:
> +/*
> + * __*_if_need version is used in cases that you don't want write a bit which
> + * have been set / clear, to avoid dirty cacheline.
> + */
> +static inline void __set_bit_if_need(int nr, volatile unsigned long *addr)
"if_need" is gramatically incorrect - it should be "if_needed".
And __set_bit_if_needed is too long. But I can't think of anything
shorter, unless we do something lame like __set_bit2().
__set_bit_if_clear() isn't too bad?
Also, your changelog still doesn't include the results of the
quantitative testing which you performed to demonstrate that these code
sites will benefit from this conversion. Please copy all that info
into the changelog!
prev parent reply other threads:[~2015-02-18 21:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 7:06 [RFC] test_bit " Wang, Yalin
2015-02-10 7:11 ` [RFC V2] " Wang, Yalin
2015-02-10 20:22 ` Andrew Morton
2015-02-10 20:49 ` Linus Torvalds
2015-02-10 22:46 ` Kirill A. Shutemov
2015-02-10 23:29 ` Linus Torvalds
2015-02-15 8:27 ` [RFC V3] test bit " Wang, Yalin
2015-02-18 21:27 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218132715.be18865751a83820f635f04e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Neil.Gao@sonymobile.com \
--cc=Yalin.Wang@sonymobile.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®