From: Morten Rasmussen <morten.rasmussen@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"preeti@linux.vnet.ibm.com" <preeti@linux.vnet.ibm.com>,
"kamalesh@linux.vnet.ibm.com" <kamalesh@linux.vnet.ibm.com>,
"riel@redhat.com" <riel@redhat.com>,
"efault@gmx.de" <efault@gmx.de>,
"nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>,
Dietmar Eggemann <Dietmar.Eggemann@arm.com>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>
Subject: Re: [PATCH RESEND v9 05/10] sched: make scale_rt invariant with frequency
Date: Thu, 19 Feb 2015 17:18:24 +0000 [thread overview]
Message-ID: <20150219171824.GC22059@e105550-lin.cambridge.arm.com> (raw)
In-Reply-To: <20150219165241.GL5029@twins.programming.kicks-ass.net>
On Thu, Feb 19, 2015 at 04:52:41PM +0000, Peter Zijlstra wrote:
> On Thu, Jan 15, 2015 at 11:09:25AM +0100, Vincent Guittot wrote:
> > The average running time of RT tasks is used to estimate the remaining compute
> > capacity for CFS tasks. This remaining capacity is the original capacity scaled
> > down by a factor (aka scale_rt_capacity). This estimation of available capacity
> > must also be invariant with frequency scaling.
> >
> > A frequency scaling factor is applied on the running time of the RT tasks for
> > computing scale_rt_capacity.
> >
> > In sched_rt_avg_update, we scale the RT execution time like below:
> > rq->rt_avg += rt_delta * arch_scale_freq_capacity() >> SCHED_CAPACITY_SHIFT
> >
> > Then, scale_rt_capacity can be summarized by:
> > scale_rt_capacity = SCHED_CAPACITY_SCALE -
> > ((rq->rt_avg << SCHED_CAPACITY_SHIFT) / period)
> >
> > We can optimize by removing right and left shift in the computation of rq->rt_avg
> > and scale_rt_capacity
>
> So far so good..
>
> > The call to arch_scale_frequency_capacity in the rt scheduling path might be
> > a concern for RT folks because I'm not sure whether we can rely on
> > arch_scale_freq_capacity to be short and efficient ?
>
> No, that is, arch_scale_frequency_capacity() _must_ be short and
> efficient, event for the fair class, its called in very hot paths.
... and very frequently too.
> I think we've talked about this before; this function should basically
> only return a cached value, which is periodically updated through some
> means.
Agreed. I think it is reasonable to assume that the arch code
implementing arch_scale_freq_capacity() does it's best to make it fast
for the particular architecture. Since the scaling factor to be returned
by the function may be obtained in different ways for different
architectures the caching should be done on the arch side.
> But lets see, I've yet to see an actual implementation of it; and its
> got that sd argument, curious what you're going to do with that.
So we do have an RFC implementation for ARM already which I posted in
December and is also included in the rather large RFC posting I did some
weeks ago. That one basically reads two atomic variables and returns the
ratio between the two. I have yet to benchmark how horribly expensive it
is though. The sd argument is ignored. We might actually not need it at
all?
next prev parent reply other threads:[~2015-02-19 17:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 10:09 [PATCH RESEND v9 00/10] sched: consolidation of CPU capacity and usage Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 01/10] sched: add utilization_avg_contrib Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 02/10] sched: Track group sched_entity usage contributions Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 03/10] sched: remove frequency scaling from cpu_capacity Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 04/10] sched: Make sched entity usage tracking scale-invariant Vincent Guittot
2015-02-19 16:34 ` Peter Zijlstra
2015-02-19 17:02 ` Morten Rasmussen
2015-02-19 17:05 ` Peter Zijlstra
2015-02-20 9:21 ` Morten Rasmussen
2015-01-15 10:09 ` [PATCH RESEND v9 05/10] sched: make scale_rt invariant with frequency Vincent Guittot
2015-02-19 16:52 ` Peter Zijlstra
2015-02-19 17:18 ` Morten Rasmussen [this message]
2015-02-24 10:21 ` Vincent Guittot
2015-02-24 11:33 ` Dietmar Eggemann
2015-01-15 10:09 ` [PATCH RESEND v9 06/10] sched: add per rq cpu_capacity_orig Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 07/10] sched: get CPU's usage statistic Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 08/10] sched: replace capacity_factor by usage Vincent Guittot
2015-02-20 11:14 ` Peter Zijlstra
2015-02-20 13:31 ` Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 09/10] sched: add SD_PREFER_SIBLING for SMT level Vincent Guittot
2015-01-15 10:09 ` [PATCH RESEND v9 10/10] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2015-02-20 11:27 ` Peter Zijlstra
2015-02-20 13:54 ` Vincent Guittot
2015-02-20 16:26 ` Peter Zijlstra
2015-02-19 12:49 ` [PATCH RESEND v9 00/10] sched: consolidation of CPU capacity and usage Morten Rasmussen
2015-02-20 11:34 ` Peter Zijlstra
2015-02-20 11:52 ` Morten Rasmussen
2015-02-20 14:13 ` Vincent Guittot
2015-02-20 14:35 ` Morten Rasmussen
2015-02-20 14:54 ` Vincent Guittot
2015-02-23 15:45 ` Morten Rasmussen
2015-02-24 10:38 ` Vincent Guittot
2015-02-24 11:29 ` Morten Rasmussen
2015-02-24 12:18 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219171824.GC22059@e105550-lin.cambridge.arm.com \
--to=morten.rasmussen@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=efault@gmx.de \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®