mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <david.ahern@oracle.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf: Only include tsc file for x86
Date: Thu, 19 Feb 2015 20:42:35 +0100	[thread overview]
Message-ID: <20150219194235.GA1707@krava.redhat.com> (raw)
In-Reply-To: <1424370153-128274-1-git-send-email-david.ahern@oracle.com>

On Thu, Feb 19, 2015 at 01:22:33PM -0500, David Ahern wrote:
> perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make
> inclusion of tsc.c dependent on x86 as well.

hum, should we move it to arch/x86/util/tsc.c and remove util/tsc.c?

looks like it's used only by test tsc code, which is enabled
for x86 only anyway..

jirka

> 
> Signed-off-by: David Ahern <david.ahern@oracle.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/util/Build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index 32f9327b1a97..4c7095785ba0 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -71,7 +71,7 @@ libperf-y += stat.o
>  libperf-y += record.o
>  libperf-y += srcline.o
>  libperf-y += data.o
> -libperf-y += tsc.o
> +libperf-$(CONFIG_X86) += tsc.o
>  libperf-y += cloexec.o
>  libperf-y += thread-stack.o
>  
> -- 
> 1.9.3
> 

  reply	other threads:[~2015-02-19 20:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 18:22 David Ahern
2015-02-19 19:42 ` Jiri Olsa [this message]
2015-02-20  8:36   ` Adrian Hunter
2015-02-20 16:40     ` David Ahern
2015-02-20 18:53       ` Jiri Olsa
2015-03-03  6:21 ` [tip:perf/core] perf tools: " tip-bot for David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150219194235.GA1707@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=david.ahern@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome