From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbbBTDXa (ORCPT ); Thu, 19 Feb 2015 22:23:30 -0500 Received: from mo-sw-fb1501.iij4u.or.jp ([210.130.239.243]:49749 "EHLO mo-sw-fb.iij4u.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711AbbBTDX1 (ORCPT ); Thu, 19 Feb 2015 22:23:27 -0500 X-Greylist: delayed 1816 seconds by postgrey-1.27 at vger.kernel.org; Thu, 19 Feb 2015 22:23:26 EST Date: Fri, 20 Feb 2015 11:52:57 +0900 (JST) Message-Id: <20150220.115257.256613837.kkojima@rr.iij4u.or.jp> To: joseph@codesourcery.com Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH RFC] Update kernel math-emu code from current glibc soft-fp From: Kaz Kojima In-Reply-To: References: <20150219.132122.204795202277130266.davem@davemloft.net> X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joseph Myers wrote: > Please try this patch on top of the previous one. The way abort is > redefined in the kernel code doesn't work for one place using it in an > expression; this patch changes a comma expression to a statement > expression. This didn't appear in my powerpc testing because the powerpc > emulation never uses FP_FROM_INT; I'm not sure how Kaz's sh testing > avoided the problem appearing there. My bad. It turned out that I've configured the kernel wrongly and CONFIG_SH_FPU_EMU isn't enabled. With the proper configuration, the build got the similar error with sparc64 during compiling arch/sh/math.c and your patch for op-common.h fixes it. Regards, kaz