From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754970AbbBTV3F (ORCPT ); Fri, 20 Feb 2015 16:29:05 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:46832 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555AbbBTV3C (ORCPT ); Fri, 20 Feb 2015 16:29:02 -0500 Date: Fri, 20 Feb 2015 16:28:59 -0500 (EST) Message-Id: <20150220.162859.1939233097658138953.davem@davemloft.net> To: arnd@arndb.de Cc: netdev@vger.kernel.org, acme@ghostprotocols.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net/appletalk: LTPC needs virt_to_bus From: David Miller In-Reply-To: <6100590.gsNqMCFyRS@wuerfel> References: <6100590.gsNqMCFyRS@wuerfel> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Feb 2015 13:29:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 18 Feb 2015 20:48:54 +0100 > The ltpc driver is rather outdated and does not get built on most > platforms because it requires the ISA_DMA_API symbol. However > there are some ARM platforms that have ISA_DMA_API but no virt_to_bus, > and they get this build error when enabling the ltpc driver. > > drivers/net/appletalk/ltpc.c: In function 'handlefc': > drivers/net/appletalk/ltpc.c:380:2: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration] > set_dma_addr(dma,virt_to_bus(ltdmacbuf)); > ^ > > This adds another dependency in Kconfig to avoid that configuration. > > Signed-off-by: Arnd Bergmann Applied, thank you.