From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754617AbbBTNOB (ORCPT ); Fri, 20 Feb 2015 08:14:01 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:44259 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754105AbbBTNN7 (ORCPT ); Fri, 20 Feb 2015 08:13:59 -0500 Date: Fri, 20 Feb 2015 18:43:53 +0530 From: Tapasweni Pathak To: gregkh@linuxfoundation.org, vinc94@gmail.com, roberta.dobrescu@gmail.com, sachin.kamat@samsung.com, ebru.akagunduz@gmail.com, damm+renesas@opensource.se, chris@rorvick.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: tapaswenipathak@gmail.com, julia.lawall@lip6.fr Subject: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC Message-ID: <20150220131336.GA22731@kt-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To avoid deadlock, do not call blocking functions with spinlocks held. Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile doesn't have enough free pages but will not sleep and hence deadlock can be avoided. Found by Coccinelle. Signed-off-by: Tapasweni Pathak --- Is there any other way this can be fixed as it is better to avoid GFP_ATOMIC? drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 4be646c..6c1de27 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -2794,7 +2794,7 @@ static int nbu2ss_ep_queue( if (ep->virt_buf == NULL) ep->virt_buf = (u8 *)dma_alloc_coherent( NULL, PAGE_SIZE, - &ep->phys_buf, GFP_KERNEL | GFP_DMA); + &ep->phys_buf, GFP_ATOMIC | GFP_DMA); if (ep->epnum > 0) { if (ep->direct == USB_DIR_IN) memcpy(ep->virt_buf, req->req.buf, -- 1.7.9.5