From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853AbbBTQvA (ORCPT ); Fri, 20 Feb 2015 11:51:00 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:55937 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754627AbbBTQu7 (ORCPT ); Fri, 20 Feb 2015 11:50:59 -0500 Date: Fri, 20 Feb 2015 08:50:28 -0800 From: Guenter Roeck To: Krzysztof Kozlowski Cc: Cezary Jackiewicz , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Garrett , stable@vger.kernel.org Subject: Re: [RFT PATCH v3 1/2] compal-laptop: Fix leaking hwmon device Message-ID: <20150220165028.GD22752@roeck-us.net> References: <1424438015-3006-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424438015-3006-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.54E765F2.0223,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 18 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 20, 2015 at 02:13:34PM +0100, Krzysztof Kozlowski wrote: > The commit c2be45f09bb0 ("compal-laptop: Use > devm_hwmon_device_register_with_groups") wanted to change the > registering of hwmon device to resource-managed version. It mostly did > it except the main thing - it forgot to use devm-like function so the > hwmon device leaked after device removal or probe failure. > > Signed-off-by: Krzysztof Kozlowski > Fixes: c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") > Cc: Acked-by: Guenter Roeck Guenter