From: Andrew Morton <akpm@linux-foundation.org>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode
Date: Fri, 20 Feb 2015 18:00:55 -0800 [thread overview]
Message-ID: <20150220180055.443bbce8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20150221.101328.1613471465739082397.konishi.ryusuke@lab.ntt.co.jp>
On Sat, 21 Feb 2015 10:13:28 +0900 (JST) Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> wrote:
> I've got a warning from 0day kernel testing backend:
>
> fs/nilfs2/btree.c: In function 'nilfs_btree_root_broken':
> >> fs/nilfs2/btree.c:394:3: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'ino_t' [-Wformat=]
> pr_crit("NILFS: bad btree root (inode number=%lu): level = %d,
> flags = 0x%x, nchildren = %d\n",
> ^
>
> This is output for s390 arch since ino_t doesn't mean "unsigned long"
> in s390.
alpha uses uint for ino_t as well.
It seems a bit pointless - neither arch uses ino_t in ./arch/ code. I
suspect both could switch to ulong, which would make the world a
slightly better place.
next prev parent reply other threads:[~2015-02-21 2:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 13:46 [PATCH 0/1] " Ryusuke Konishi
2015-02-20 13:46 ` [PATCH 1/1] " Ryusuke Konishi
2015-02-20 21:58 ` Andrew Morton
2015-02-21 0:22 ` Ryusuke Konishi
2015-02-21 1:13 ` Ryusuke Konishi
2015-02-21 2:00 ` Andrew Morton [this message]
2015-02-21 2:37 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220180055.443bbce8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®