From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932070AbbBUHOg (ORCPT ); Sat, 21 Feb 2015 02:14:36 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:56610 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbbBUHOe (ORCPT ); Sat, 21 Feb 2015 02:14:34 -0500 Date: Sat, 21 Feb 2015 01:14:00 -0600 From: Felipe Balbi To: Pavel Machek CC: Felipe Balbi , Pali =?iso-8859-1?Q?Roh=E1r?= , Linux USB Mailing List , Aaro Koskinen , Sebastian Reichel , Subject: Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls Message-ID: <20150221071400.GB24869@saruman.tx.rr.com> Reply-To: References: <1422918921-5472-1-git-send-email-balbi@ti.com> <201502032057.11166@pali> <201502051338.59040@pali> <201502200109.48793@pali> <20150220030611.GA19507@saruman.tx.rr.com> <20150220082750.GC14057@amd> <20150220143906.GA1707@saruman.tx.rr.com> <20150220211552.GB28995@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IrhDeMKUP4DT/M7F" Content-Disposition: inline In-Reply-To: <20150220211552.GB28995@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IrhDeMKUP4DT/M7F Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Feb 20, 2015 at 10:15:52PM +0100, Pavel Machek wrote: > On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: > > On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > > > In current state I review all 3 patches as: > > > > > > > > >=20 > > > > > > > > > Rejected-by: Pali Roh=E1r > > > > > > > > > [It breaks booting Nokia N900 device] > > > > > > > >=20 > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > > > > on AM335x which has the same musb IP. > > > > > > >=20 > > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > > > > it. > > > > > >=20 > > > > > > Actually when I reverted only that patch which adds line: > > > > > >=20 > > > > > > pm_runtime_irq_safe(musb->controller) > > > > > >=20 > > > > > > then early boot crash disappeared. > > > > > >=20 > > > > > > But other two patches did not fixed support for external .ko > > > > > > gadget modules. State is same -- crash after modprobe. > > > > >=20 > > > > > Here is crash from qemu when musb is compiled into kernel: > > > > >=20 > > > > > [ 0.641662] Unable to handle kernel NULL pointer dereference a= t virtual address 00000000 > > > > > [ 0.642211] pgd =3D c0004000 > > > ... > > > > > [ 0.672882] ---[ end Kernel panic - not syncing: Attempted to = kill init! exitcode=3D0x0000000b > > > > > [ 0.672882] > > > > >=20 > > > > > Reason why it crashes is because when function > > > > > omap2430_runtime_resume() is called pointer to functions=20 > > > > > musb_readl and musb_writel are both NULL. And so NULL pointer > > > > > dereference. > > > >=20 > > > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?= h=3Dtesting/next&id=3D1861a2c60351a390272b3395f4d88480cdfd9e58 > > > > > > >=20 > > > So you commit a fix to your internal branch without telling Pali, who > > > is actively debugging same problem at the same time, and then you just > > > send him url without at least saying "sorry"? > >=20 > > grow up... why do I have to say sorry for fixing a problem ? Why do I > > have to let you know I committed something to my branch ? It's the >=20 > Because that's polite thing to do when you break someone elses system? when did I break anything from you ? I sent you a patch to test which you tested and reported it didn't work and the patch was removed from my queue because of that. After that you completely refused to do any work/debug related to an itch only *you* had to start with. Seen as you just don't care to help yourself, why should I ? You're 100% capable of debugging the problems you reported which I ended up debugging even without having any HW which reproduced the failured. Not to mention that since the beginning *you* have been the unpolite one, completely reluctant to test anything or find logs because, aparently, that's a waste of your o-so-valuable time. So no, you DO NOT deserve any politeness. When you change your attitude and start scratching your own itches, then we can talk about politeness; until then, get used to a similarly aggressive attitude towards you. --=20 balbi --IrhDeMKUP4DT/M7F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU6DA4AAoJEIaOsuA1yqREHhIQALZ9CIjpZrzwZdQISLCKbil2 145SApdAOA/2hiw4igDNp2m8TBDG5kCSbXJqErazbMOTVYsCfEgIeX39pSXne4n1 QyOKpHFqfMvoKxp8h6VfUSev8sM8BUBP+K9QtFPsnRaEzHmDxmiHUnnFlm0ht0vQ bflwbsB9GO8tYR13squxmpRI2SImb3j4pVkGkpb3NVWcnOtMLkhg/2TXemaxXFNo EJQTtfAuRBL1Cfky+Uy8HJoNzCg6sfF4S7w+MjJawTHRfWREtCRExRRWXyIEnZ+U QKk2SQ4y3udJXq4K0kB8Fv7qbQhig32uObmj+OhZEX2UvtUqXpXdCLpSeqtFVJBM 8BnAjQyfrolxkjvVTBynhOz66MNUYMGfvtnWTHTJKQIZ5JyuJmoMHFTJSI0YQs2u fRPTv55P5rC3dQaFdfbCR12fPRTZisfCMV7c99kLeZ+lfUZ854RLwK5Z5mtfUzGI waPbNJMlbxNni4fSnHdxCBiN9Fb8dkokgNqDB+6NT/mGpwXUWWhP83OPspYqR5oB I7mVppXQCyevbX6YsMcEaDeSfR4uHazjDphvfZvZILkz8bXI/xaG9/xSI5IR7vTV 0Kxv9NwWUzZHkvcLQ5jQtf1Yk7p3+h66jZEBRClrNQaP8g/LDzjNYtbK+4HAm4BW j6r6yq4lAiT3GJ3v8lTN =bcOm -----END PGP SIGNATURE----- --IrhDeMKUP4DT/M7F--