From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752341AbbBVV3u (ORCPT ); Sun, 22 Feb 2015 16:29:50 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:49579 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbbBVV3s (ORCPT ); Sun, 22 Feb 2015 16:29:48 -0500 Date: Sun, 22 Feb 2015 16:29:41 -0500 (EST) Message-Id: <20150222.162941.780862111589113271.davem@davemloft.net> To: sasha.levin@oracle.com Cc: herbert@gondor.apana.org.au, tgraf@suug.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rhashtable: initialize all rhashtable walker members From: David Miller In-Reply-To: <54EA49E5.8040206@oracle.com> References: <1424552111-12077-1-git-send-email-sasha.levin@oracle.com> <20150222.155838.307897095859530348.davem@davemloft.net> <54EA49E5.8040206@oracle.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sun, 22 Feb 2015 13:29:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sasha Levin Date: Sun, 22 Feb 2015 16:28:05 -0500 > On 02/22/2015 03:58 PM, David Miller wrote: >> From: Sasha Levin >> Date: Sat, 21 Feb 2015 15:55:11 -0500 >> >>> Commit "rhashtable: Introduce rhashtable_walk_*" forgot to initialize the >>> members of struct rhashtable_walker after allocating it, which caused >>> an undefined value for 'resize' which is used later on. >>> >>> Signed-off-by: Sasha Levin >> >> Commits should be referred to by SHA1 ID as well as the commit >> header text (in parenthesis and double quotes). > > It wasn't (isn't?) in Linus' tree yet, so I didn't want to refer to > it by a SHA1 ID which would change. Commit IDs in my tree _NEVER_ change.