From: David Miller <davem@davemloft.net>
To: ameenali023@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] __aligned(size) is preferred over __attribute__((aligned(size)))
Date: Sun, 22 Feb 2015 17:02:38 -0500 (EST) [thread overview]
Message-ID: <20150222.170238.779470624458267514.davem@davemloft.net> (raw)
In-Reply-To: <1424641236-7671-1-git-send-email-ameenali023@gmail.com>
cFrom: Ameen Ali <ameenali023@gmail.com>
Date: Sun, 22 Feb 2015 23:40:36 +0200
> Signed-off-by: Ameen Ali <AmeenAli023@gmail.com>
Applied, but please use a proper Subject line next time,
in particular you should put a proper subsystem prefix.
In this case, "net: " would be an appropriate prefix.
Otherwise people scanning the shortlog in the repository
cannot tell where you are making your changes.
What if we had 100 commits all doing this same transformation?
It is the subsystem prefix that helps people see what is unique
in each such change.
prev parent reply other threads:[~2015-02-22 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 21:40 Ameen Ali
2015-02-22 22:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150222.170238.779470624458267514.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ameenali023@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®