From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197AbbBWVi6 (ORCPT ); Mon, 23 Feb 2015 16:38:58 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:37971 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbbBWVi4 (ORCPT ); Mon, 23 Feb 2015 16:38:56 -0500 Date: Mon, 23 Feb 2015 16:38:54 -0500 (EST) Message-Id: <20150223.163854.880151768241069377.davem@davemloft.net> To: stathis.voukelatos@linn.co.uk Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/3] Linn Ethernet packet sniffer driver From: David Miller In-Reply-To: <34013795c99ef50fac3d2c72717971563148578c.1424698609.git.stathis.voukelatos@linn.co.uk> References: <34013795c99ef50fac3d2c72717971563148578c.1424698609.git.stathis.voukelatos@linn.co.uk> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Mon, 23 Feb 2015 13:38:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stathis Voukelatos Date: Mon, 23 Feb 2015 14:26:22 +0000 > Driver for the Ethernet Mii packet sniffer H/W module found in > the IMG Pistachio SoC. > > Signed-off-by: Stathis Voukelatos You really have to explain what this thing does, how it is used, what APIs are made use of to maniulate this device, etc. Nobody knows what the packet sniffer module by your company is. I also anticipate that once you describe adequately how this thing behaves I won't like it, and I'll prefer that you integrate support for your device using an exising facility such as AF_PACKET, extending it if need be. I am very far away from applying this series at this point, it needs a lot more work and explanations.