From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753099AbbBWMDn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Feb 2015 07:03:43 -0500
Received: from pandora.arm.linux.org.uk ([78.32.30.218]:57844 "EHLO
	pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752410AbbBWMDl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Feb 2015 07:03:41 -0500
Date: Mon, 23 Feb 2015 12:03:29 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Lee Jones <lee@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
        Mike Turquette <mturquette@linaro.org>,
        Bryan Huntsman <bryanh@codeaurora.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev()
Message-ID: <20150223120329.GN8656@n2100.arm.linux.org.uk>
References: <1424692181-14455-1-git-send-email-andriy.shevchenko@linux.intel.com>
 <1424692181-14455-2-git-send-email-andriy.shevchenko@linux.intel.com>
 <20150223115356.GA21609@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150223115356.GA21609@x1>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 23, 2015 at 11:53:56AM +0000, Lee Jones wrote:
> On Mon, 23 Feb 2015, Andy Shevchenko wrote:
> >  arch/arm/mach-msm/clock-pcom.c         |  9 +++++----
> >  arch/arm/mach-vexpress/spc.c           |  5 ++++-
> >  arch/mips/ath79/clock.c                |  6 +++---
> >  drivers/clk/clk-bcm2835.c              | 12 +++++++-----
> >  drivers/clk/clk-max-gen.c              |  9 ++++-----
> >  drivers/clk/clk-xgene.c                |  6 +++---
> >  drivers/clk/clkdev.c                   | 15 ++++++++++-----
> >  drivers/clk/samsung/clk-pll.c          | 13 ++++++++-----
> >  drivers/clk/samsung/clk-s3c2410-dclk.c | 19 +++++++++---------
> >  drivers/clk/samsung/clk.c              | 35 +++++++++++++++++++---------------
> >  include/linux/clkdev.h                 |  2 +-
> >  11 files changed, 75 insertions(+), 56 deletions(-)
> 
> What's tying all of these changes together?  It would be better
> (simpler for you) if you split them up by subsystem and resubmitted.

I think maybe, just maybe, you might get the answer to that if you read
the patch.

You can't change the function signature without creating lots of warnings
and causing regressions.

Yes, the function could be renamed whilst doing this change, but that's
really quite sub-standard in an already busy namespace.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.