From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079AbbBWV4v (ORCPT ); Mon, 23 Feb 2015 16:56:51 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:53557 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbbBWV4t (ORCPT ); Mon, 23 Feb 2015 16:56:49 -0500 Date: Mon, 23 Feb 2015 13:56:34 -0800 From: Guenter Roeck To: Matthew Wilcox Cc: Arnd Bergmann , Geert Uytterhoeven , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Andrew Morton , linux-sh@vger.kernel.org, Vineet Gupta Subject: Re: fs: dax: do not build on ARC or SH Message-ID: <20150223215634.GA23928@roeck-us.net> References: <5778538.KJ98x3yxkB@wuerfel> <20150223184025.GD2780@wil.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150223184025.GD2780@wil.cx> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.54EBA221.00E3,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 5 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 23, 2015 at 01:40:25PM -0500, Matthew Wilcox wrote: > On Mon, Feb 23, 2015 at 12:29:45PM +0100, Arnd Bergmann wrote: > > The DAX implementation relies on the architecture to provide a working > > copy_user_page() function, as reported by Michael Ellerman's kisskb > > build bot: > > > > fs/dax.c: error: implicit declaration of function 'copy_user_page' [-Werror=implicit-function-declaration]: => 266:2 > > > > We already have a list of architectures that are known to be incompatible, > > but the list is missing ARC and SH at the moment. Further, blackfin and > > c6x also lack support for this function, but are already excluded because > > they do not support MMU-based kernels. > > I've got a short list of patches for DAX; I'll add this one to the list. > > Have the maintainers of these architectures been notified that they're > missing a core piece of kernel functionality? > Guess there a philosophical difference in opinion if the architecture code should (have to) provide copy_user_page() or not outside the architecture code itself. After all, fs/dax.c _is_ the only user of this function outside the architecture code. Guenter