From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153AbbBWWQX (ORCPT ); Mon, 23 Feb 2015 17:16:23 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:55390 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbbBWWQU (ORCPT ); Mon, 23 Feb 2015 17:16:20 -0500 Date: Mon, 23 Feb 2015 14:15:38 -0800 From: Guenter Roeck To: Christoph Hellwig Cc: Matthew Wilcox , Arnd Bergmann , Geert Uytterhoeven , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Andrew Morton , linux-sh@vger.kernel.org, Vineet Gupta Subject: Re: fs: dax: do not build on ARC or SH Message-ID: <20150223221538.GA25109@roeck-us.net> References: <5778538.KJ98x3yxkB@wuerfel> <20150223184025.GD2780@wil.cx> <20150223215634.GA23928@roeck-us.net> <20150223215847.GA29052@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150223215847.GA29052@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.54EBA6B3.0233,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 6 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 23, 2015 at 01:58:47PM -0800, Christoph Hellwig wrote: > On Mon, Feb 23, 2015 at 01:56:34PM -0800, Guenter Roeck wrote: > > Guess there a philosophical difference in opinion if the architecture code > > should (have to) provide copy_user_page() or not outside the architecture > > code itself. After all, fs/dax.c _is_ the only user of this function outside > > the architecture code. > > Given that copy_user_page just is an optimized version of copy_page > all these architectures should just grab the trivial macro defintion > from the asm-generic version so that we could avoid this discussion. > I tried to do just that, for mips, with little success. https://patchwork.linux-mips.org/patch/9175/ Presumably, if copy_page() followed by a conditional flush_data_cache_page() does not work on mips, I would assume that copy_page() without flush does not work either. Guenter