From: David Cohen <david.a.cohen@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Robert Baldyga <r.baldyga@samsung.com>,
heikki.krogerus@linux.intel.com
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
baolu.lu@linux.intel.com, balbi@ti.com
Subject: Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)
Date: Tue, 24 Feb 2015 11:18:06 -0800 [thread overview]
Message-ID: <20150224191806.GB13094@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <20150220191700.GB15303@psi-dev26.jf.intel.com>
Hi,
[snip]
> Felipe suggested to "divide to conquer" instead of having a single
> extcon driver to handle all these functions:
>
> - The mux functions would be controlled by a possible new pinctrl-gpio
> driver (Linus, your input here would be nice :)
> - The VBUS would be a fixed regulator
> - The USB ID would make usage of existent extcon-gpio
>
> But the on fw side, this is a single ACPI device representing a virtual
> device for USB OTG port, which is nothing but a bunch of independent
> GPIOs.
>
> I could make a mfd driver to register devices for those simpler and more
> generic drivers, but according to [1] community recognized it as a hack
> with ACPI since I'd need to give them the GPIO without requesting on
> mfd.
I believe this case could be resumed in:
Would be [1] acceptable for mfd drivers?
- If yes, I can split this driver into more generic ones
- If no, I see no other option but having this driver fully controlling
the USB OTG port.
BR, David
[1] https://lkml.org/lkml/2014/12/18/82
next prev parent reply other threads:[~2015-02-24 19:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 22:43 [RFC/PATCH] " David Cohen
2014-12-23 1:25 ` Peter Chen
2014-12-23 19:40 ` David Cohen
2014-12-24 3:08 ` Peter Chen
2014-12-24 22:46 ` David Cohen
2014-12-23 13:10 ` Sergei Shtylyov
2014-12-23 19:57 ` David Cohen
2014-12-23 20:09 ` Sergei Shtylyov
2014-12-23 20:43 ` David Cohen
2014-12-24 0:29 ` Felipe Balbi
2014-12-24 22:43 ` David Cohen
2014-12-26 4:49 ` Felipe Balbi
2015-02-17 19:18 ` David Cohen
2015-02-17 19:25 ` Felipe Balbi
2015-02-17 19:35 ` David Cohen
2015-02-18 10:17 ` Mika Westerberg
2015-02-18 17:53 ` David Cohen
2015-01-08 19:23 ` Linus Walleij
2015-02-17 19:20 ` David Cohen
2015-02-19 19:59 ` [PATCH v2] " David Cohen
2015-02-19 22:39 ` Paul Bolle
2015-02-20 19:02 ` David Cohen
2015-02-20 19:09 ` Felipe Balbi
2015-02-20 19:18 ` David Cohen
2015-02-20 19:10 ` Paul Bolle
2015-02-20 19:18 ` David Cohen
2015-02-20 6:41 ` Robert Baldyga
2015-02-20 9:53 ` Linus Walleij
2015-02-20 19:17 ` David Cohen
2015-02-20 19:36 ` Felipe Balbi
2015-02-20 19:59 ` David Cohen
2015-02-20 20:00 ` Felipe Balbi
2015-02-20 20:40 ` David Cohen
2015-03-07 20:03 ` Linus Walleij
2015-02-24 19:18 ` David Cohen [this message]
2015-03-07 20:06 ` Linus Walleij
2015-03-09 16:16 ` Felipe Balbi
2015-03-09 19:10 ` David Cohen
2015-03-16 16:46 ` David Cohen
2015-03-16 16:46 ` David Cohen
2015-03-19 8:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224191806.GB13094@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=balbi@ti.com \
--cc=baolu.lu@linux.intel.com \
--cc=cw00.choi@samsung.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome