mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stefan Sauer <ensonic@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mma8450: add parent device
Date: Wed, 25 Feb 2015 17:12:49 -0800	[thread overview]
Message-ID: <20150226011249.GB25965@dtor-ws> (raw)
In-Reply-To: <1424854388-31227-1-git-send-email-ensonic@google.com>

On Wed, Feb 25, 2015 at 09:53:08AM +0100, Stefan Sauer wrote:
> Add the parent device so that udev can show the full hierarchy. This avoids the
> device showing up under /devices/virtual/input instead of the i2c bus it is
> actually attached to.
> 
> Signed-off-by: Stefan Sauer <ensonic@google.com>

Applied, thank you.

> ---
>  drivers/input/misc/mma8450.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
> index 59d4dcd..9822877 100644
> --- a/drivers/input/misc/mma8450.c
> +++ b/drivers/input/misc/mma8450.c
> @@ -187,6 +187,7 @@ static int mma8450_probe(struct i2c_client *c,
>  	idev->private		= m;
>  	idev->input->name	= MMA8450_DRV_NAME;
>  	idev->input->id.bustype	= BUS_I2C;
> +	idev->input->dev.parent = &c->dev;
>  	idev->poll		= mma8450_poll;
>  	idev->poll_interval	= POLL_INTERVAL;
>  	idev->poll_interval_max	= POLL_INTERVAL_MAX;
> -- 
> 2.2.0.rc0.207.ga3a616c
> 

-- 
Dmitry

      reply	other threads:[~2015-02-26  1:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25  8:53 Stefan Sauer
2015-02-26  1:12 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226011249.GB25965@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=ensonic@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®