From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932350AbbBZNMH (ORCPT ); Thu, 26 Feb 2015 08:12:07 -0500 Received: from down.free-electrons.com ([37.187.137.238]:43929 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932078AbbBZNME convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2015 08:12:04 -0500 Date: Thu, 26 Feb 2015 14:12:01 +0100 From: Boris Brezillon To: Jean-Christophe PLAGNIOL-VILLARD Cc: Nicolas FERRE , Alexandre Belloni , Linus Walleij , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jean-Jacques Hiblot Subject: Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods Message-ID: <20150226141201.670e6e18@bbrezillon> In-Reply-To: <95765FA2-E9BF-4A66-B46D-2491869B0A14@jcrosoft.com> References: <1423419822-6258-1-git-send-email-boris.brezillon@free-electrons.com> <95765FA2-E9BF-4A66-B46D-2491869B0A14@jcrosoft.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Feb 2015 15:50:36 +0800 Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On Feb 9, 2015, at 10:50 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > >> On Feb 9, 2015, at 2:23 AM, Boris Brezillon wrote: > >> > >> The gpiochip_lock_as_irq call can fail and return an error, while the > >> irq_startup is not expected to fail (returns an unsigned int which is not > >> checked by irq core code). > >> > >> irq_request/release_resources functions have been created to address this > >> problem. > >> > >> Move gpiochip_lock/unlock_as_irq calls into > >> irq_request/release_resources functions to prevent using a gpio as an irq > >> if the gpiochip_lock_as_irq call failed. > >> > >> Signed-off-by: Boris Brezillon > >> — > > > > I’m travelling will take a look end of the week > > just get back from travelling will take a look after Chinese new year > as all my hw are at the office Ping -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com